-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add layout timers to the HIBF. #162
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 44 44
Lines 1726 1761 +35
=======================================
+ Hits 1725 1760 +35
Misses 1 1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit. If all is fine, please squash and rebase on main :)
Since we already have timers in build, I think having timers in the layout is also helpful. It is even helpful to users to check the timings of union estimation and rearrangement for their decision to enable/disable it.
And most probably all the timers can be
concurrent::no
, right @eseiler ?