Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add layout timers to the HIBF. #162

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

smehringer
Copy link
Member

@smehringer smehringer commented Nov 7, 2023

Since we already have timers in build, I think having timers in the layout is also helpful. It is even helpful to users to check the timings of union estimation and rearrangement for their decision to enable/disable it.

And most probably all the timers can be concurrent::no, right @eseiler ?

Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hibf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 10:15am

@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a85be3e) 99.94% compared to head (e075c04) 99.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          44       44           
  Lines        1726     1761   +35     
=======================================
+ Hits         1725     1760   +35     
  Misses          1        1           
Files Coverage Δ
...ude/hibf/hierarchical_interleaved_bloom_filter.hpp 100.00% <100.00%> (ø)
include/hibf/layout/data_store.hpp 100.00% <ø> (ø)
include/hibf/layout/layout.hpp 100.00% <100.00%> (ø)
src/hierarchical_interleaved_bloom_filter.cpp 100.00% <100.00%> (ø)
src/layout/compute_fpr_correction.cpp 100.00% <100.00%> (ø)
src/layout/compute_layout.cpp 100.00% <100.00%> (ø)
src/layout/hierarchical_binning.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 7, 2023
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 7, 2023
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 7, 2023
@smehringer smehringer requested a review from eseiler November 7, 2023 12:43
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 7, 2023
@smehringer smehringer marked this pull request as ready for review November 8, 2023 08:00
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Nov 8, 2023
Copy link
Member

@eseiler eseiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit. If all is fine, please squash and rebase on main :)

@seqan-actions seqan-actions added the lint [INTERNAL] used for linting label Nov 8, 2023
@seqan-actions seqan-actions removed the lint [INTERNAL] used for linting label Nov 8, 2023
@smehringer smehringer enabled auto-merge November 8, 2023 10:18
@smehringer smehringer merged commit f7c341c into seqan:main Nov 8, 2023
27 checks passed
@smehringer smehringer deleted the timers branch November 27, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants