[TEST] Add serialisation tests #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seqan-actions
added
lint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 44 45 +1
Lines 1776 1796 +20
=======================================
+ Hits 1775 1795 +20
Misses 1 1
☔ View full report in Codecov by Sentry. |
smehringer
reviewed
Nov 9, 2023
| @@ -312,6 +312,23 @@ struct config | |||
| */ | |||
| void validate_and_set_defaults(); | |||
|
|
|||
| //!\brief Two configs are equal if all options, except seqan::hibf::config::input_fn, are equal. | |||
There was a problem hiding this comment.
this is just because input_fn cannot really be checked right?
There was a problem hiding this comment.
Yes, it cant be compared, expect to nullptr. You could compare the addresses of the function that will be called, but I don't think that is what we want
Comment on lines
+12
to
+13
| std::filesystem::path path{"/some/random/path.txt"}; | ||
| seqan::hibf::test::test_serialisation(std::move(path)); |
There was a problem hiding this comment.
why are you testing the std lib?
There was a problem hiding this comment.
Because we are providing the cereal overload
smehringer
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #164
include/hibf/cereal/path.hppwas missing thecereal/types/string.hppinclude to compile