Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Reactivate rearrange_user_bins test. #190

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

smehringer
Copy link
Member

Fixes #130

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hibf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 0:18am

@smehringer smehringer requested a review from eseiler December 15, 2023 08:41
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a46510d) 99.94% compared to head (359c0b4) 99.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          46       46           
  Lines        1835     1835           
=======================================
  Hits         1834     1834           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smehringer
Copy link
Member Author

@eseiler hm it seems that clang isn't happy with the change. Seems like for clang, the distance are not 0. Could you take a look?

@eseiler
Copy link
Member

eseiler commented Dec 15, 2023

The coverage also didn't change. So we still are missing that one line :)
BTW, are the sketches all supposed to be the same?

Edit: The missed line is somewhere else, so we hit the one line at some point. I'll check clang

@eseiler eseiler enabled auto-merge December 18, 2023 12:12
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Dec 18, 2023
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Dec 18, 2023
@eseiler eseiler merged commit 63ac78a into seqan:main Dec 18, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for toolbox::rearrange_bins
3 participants