[FEATURE] Multi-Layout file #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
- Coverage 99.94% 92.47% -7.48%
==========================================
Files 45 46 +1
Lines 1820 1833 +13
Branches 0 570 +570
==========================================
- Hits 1819 1695 -124
- Misses 1 6 +5
- Partials 0 132 +132 ☔ View full report in Codecov by Sentry. |
eseiler
requested changes
Jul 8, 2024
| TEST(layout_test, read_from_partitioned_layout) | ||
| { | ||
| // layout consists of three partitions, written one after the other | ||
| std::stringstream ss{R"layout_file(#TOP_LEVEL_IBF fullest_technical_bin_idx:111 |
There was a problem hiding this comment.
Can you make something in the layout dependent on i (e.g. Some bin index), such that we can be sure that each layout is parsed?
seqan-actions
added
lint
eseiler
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility of a a single Layout file featuring multiple layouts. This is important in case of a partitioned HIBF.
When reading a layout, we formerly read until the end of the file.
Now we read either until the end of the file is reached OR a new header starts.
To read all layouts out of a layout file, one need to iteratively call
laout.read_fromon the stream.