Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Make HIBF agents copyable #211

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Jul 11, 2024

IBF agents are copyconstructible and copyassignable, but HIBF agents are not.

Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hibf ✅ Ready (Inspect) Visit Preview Jul 12, 2024 4:24pm

@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (36d2d19) to head (addbf25).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files          47       47           
  Lines        1852     1857    +5     
  Branches        5        5           
=======================================
+ Hits         1846     1851    +5     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eseiler eseiler requested a review from smehringer July 11, 2024 12:52
Copy link
Member

@smehringer smehringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking out loud:

copy constructible means

auto new_agent = other_agent;

right?

I think I agree that this should be possible.
But can you add a test?
To check if the result buffer has the correct size?

@eseiler eseiler requested a review from smehringer July 12, 2024 16:24
@seqan-actions seqan-actions added lint [INTERNAL] used for linting and removed lint [INTERNAL] used for linting labels Jul 12, 2024
@eseiler eseiler merged commit 581f21e into seqan:main Jul 15, 2024
37 checks passed
@eseiler eseiler deleted the misc/copyable branch July 15, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants