[FEATURE] emplace_exists #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seqan-actions
added
lint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 47 47
Lines 1845 1852 +7
Branches 5 5
=======================================
+ Hits 1839 1846 +7
Misses 6 6 ☔ View full report in Codecov by Sentry. |
smehringer
approved these changes
Jul 12, 2024
Comment on lines
+101
to
+106
| // Constructing the reference twice for emplace_exists would impact performance. | ||
| // No difference for emplace. | ||
| seqan::hibf::bit_vector::reference bit_reference{(*this)[idx]}; | ||
| if constexpr (check_exists) | ||
| exists &= bit_reference; | ||
| bit_reference = 1; |
There was a problem hiding this comment.
Do you mean that
if constexpr (check_exists)
exists &= (*this)[idx];
(*this)[idx] = 1;
Would construct the reference twice and is therefore slower?
There was a problem hiding this comment.
Yes, it would need to compute the bit position twice. Since there isn't much happening in emplace, doing it twice really affects performance.
emplace 50M/s
emplace_exists 47M/s
emplace_exists* 28M/s
* is with two references
seqan-actions
added
lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for dynamic HIBF.
emplace_existsis around 5% slower thanemplace.