[FEATURE] Add try_increase_bin_number_to #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seqan-actions
added
lint
|
Documentation preview available at https://docs.seqan.de/preview/seqan/hibf/253 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 51 51
Lines 1963 1974 +11
Branches 5 5
=======================================
+ Hits 1955 1966 +11
Misses 8 8 ☔ View full report in Codecov by Sentry. |
eseiler
force-pushed
the
misc/set_bins
branch
from
9c4d95e to
26defd9
Compare
seqan-actions
added
lint
eseiler
commented
Dec 12, 2024
| * \returns `true` if the number of bins was set, `false` if the number of bins was not set. | ||
| * \sa seqan::hibf::interleaved_bloom_filter::increase_bin_number_to | ||
| * | ||
| * If increasing the number of bins would require a resize, the function returns `false` and |
There was a problem hiding this comment.
Also add warning about agents being invalidated.
smehringer
approved these changes
Dec 12, 2024
| @@ -300,8 +300,20 @@ class interleaved_bloom_filter : private seqan::hibf::bit_vector | |||
| (*this)[bin.value + offset] = 0; | |||
| } | |||
|
|
|||
| /*!\brief Tries increasing the number of bins stored in the Interleaved Bloom Filter. | |||
There was a problem hiding this comment.
Suggested change
| /*!\brief Tries increasing the number of bins stored in the Interleaved Bloom Filter. | |
| /*!\brief Tries increasing the number of bins stored in the Interleaved Bloom Filter without reallocating memory. |
Comment on lines
308
to
311
| * If increasing the number of bins would require a resize, the function returns `false` and | ||
| * does not increase the number of bins. | ||
| * If old and new bin count are the same, `true` is returned. | ||
| * If the new bin count is smaller than the old bin count, `false` is returned. |
There was a problem hiding this comment.
Suggested change
| * If increasing the number of bins would require a resize, the function returns `false` and | |
| * does not increase the number of bins. | |
| * If old and new bin count are the same, `true` is returned. | |
| * If the new bin count is smaller than the old bin count, `false` is returned. | |
| * If the new bin is bigger than the current bin count: | |
| * - and if a resize is required, returns `false` and nothing happens | |
| * - and if no resize is necessary, sets the old bin count to the new and return `true` | |
| * If old and new bin count are the same, `true` is returned. | |
| * If the new bin count is smaller than the old bin count, `false` is returned. |
eseiler
force-pushed
the
misc/set_bins
branch
from
26defd9 to
9b1acaa
Compare
seqan-actions
added
lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's handy for the dynamic IBF because I need to differentiate whether increasing the number of bins is costly (resizing).
It also seems like a useful API to have; manually determining whether a resize happens is not trivial and requires some knowledge about the IBF.