Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception and terminate workflow in case config can't be read #53

Merged
merged 7 commits into from
Jul 25, 2024

Conversation

FriederikeHanssen
Copy link
Member

@FriederikeHanssen FriederikeHanssen commented Jul 25, 2024

If the function metaOut fails the workflow used to log the error but then hang and not terminate until it runs out of time. Currently, we have observed that the ConfigSlurper occasionally cannot handle some of the returned configs.

If we throw the error, the workflow fails and does not keep using ressources. In the future we could consider adding an error Strategy to at least get partial results pending the investigation of why sometimes the config parser errors out.

@drpatelh drpatelh merged commit c4c3a5a into dev Jul 25, 2024
11 checks passed
@FriederikeHanssen FriederikeHanssen deleted the viralrecon_not_found branch July 25, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants