Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added declare to docs #1649

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NGorco
Copy link

@NGorco NGorco commented May 2, 2023

Adding proper model fields definitions that doesn't conflict with vanilla Sequelize.
Addressing that problem https://sequelize.org/docs/v6/core-concepts/model-basics/#caveat-with-public-class-fields

@blankstar85
Copy link
Contributor

I was just reading the updated sequelize docs and was thinking to add the pr to this and found this. I think you should put a blurb in the docs linking to the official docs about public fields so that users can understand the need for the change and the model reference. This would be a great pr to merge.

@NGorco
Copy link
Author

NGorco commented Oct 12, 2023

@blankstar85 Thanks, will do.

@NGorco
Copy link
Author

NGorco commented Nov 8, 2023

@blankstar85 Added more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants