Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add s2 sink #927

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add s2 sink #927

wants to merge 1 commit into from

Conversation

yordis
Copy link
Contributor

@yordis yordis commented Jan 29, 2025

Signed-off-by: Yordis Prieto [email protected]

@yordis yordis force-pushed the add-s2-sink branch 6 times, most recently from ef7b7ca to e2b634f Compare January 29, 2025 01:15
@yordis yordis force-pushed the add-s2-sink branch 2 times, most recently from f63ec00 to 45f5cc6 Compare January 29, 2025 01:36
@yordis yordis force-pushed the add-s2-sink branch 2 times, most recently from 0053acd to a5ff837 Compare January 30, 2025 15:00
@yordis
Copy link
Contributor Author

yordis commented Jan 30, 2025

@acco based on this conversation, I wonder if we should have some metadata either for documentation sake, or proper control for:

  1. Delivery guarantee and capability of the Sink
  2. Batch size and limitations around the topic

Ideally, people find that info in the sink itself, except the batch size since it matters in our end.

@yordis yordis force-pushed the add-s2-sink branch 5 times, most recently from 5122cbc to ddd490e Compare January 30, 2025 15:25
yordis
yordis commented Jan 30, 2025
View reviewed changes
lib/sequin/sinks/s2/client.ex Outdated Show resolved Hide resolved
@yordis yordis requested review from acco and shikhar January 31, 2025 17:52
@yordis yordis marked this pull request as ready for review January 31, 2025 17:52
acco
acco reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@acco acco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, @yordis !

Let's get some unit tests in here, perhaps for the S2 client? Could be nice to get one integration test for the Pipeline, but it's pretty simple

lib/sequin/consumers_runtime/s2_pipeline.ex Outdated Show resolved Hide resolved
lib/sequin/consumers_runtime/s2_pipeline.ex Show resolved Hide resolved
lib/sequin/sinks/s2/client.ex Outdated Show resolved Hide resolved
@yordis
feat: add s2 sink
e8b06c7 
Signed-off-by: Yordis Prieto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acco acco acco left review comments

@shikhar shikhar Awaiting requested review from shikhar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yordis @shikhar @acco