Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IntoDeserializer for all Deserializers in serde::de::value module #2568

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

Mingun
Copy link
Contributor

@Mingun Mingun commented Aug 11, 2023

Unfortunately, blanket implementation IntoDeserializer for Deserializer is impossible right now because this would be a breaking change. External crates may have this such implementation (and serde_json actually have it for Value).

Closes #2498

@Mingun
Copy link
Contributor Author

Mingun commented Mar 3, 2024

@dtolnay, @oli-obk, can you give some feedback?

@Mingun Mingun force-pushed the into_deserializer-for-deserializers branch from 5794b96 to 9abc2ad Compare July 23, 2024 17:05
…module

Unfortunately, blanket implementation IntoDeserializer for Deserializer is impossible
right now because this would be a breaking change. External crates may have this
such implementation (and serde_json actually have it for Value)
@Mingun Mingun force-pushed the into_deserializer-for-deserializers branch from 9abc2ad to 9cda015 Compare October 25, 2024 14:18
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dtolnay dtolnay merged commit 210373b into serde-rs:master Oct 28, 2024
15 checks passed
@Mingun Mingun deleted the into_deserializer-for-deserializers branch October 28, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Consider implementing IntoDeserializer for serde's IntoDeserializer impls
2 participants