Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change MessageUpdateEvent to just contain a full Message #3061

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Change MessageUpdateEvent to just contain a full Message #3061

merged 1 commit into from
Jan 19, 2025

Conversation

GnomedDev
Copy link
Member

Needs a basic test, but should be good.

discord/discord-api-docs#7017

@github-actions github-actions bot added model Related to the `model` module. cache Related to the `cache`-feature. gateway Related to the `gateway` module. examples Related to Serenity's examples. labels Nov 25, 2024
@GnomedDev GnomedDev added needs-testing A PR that should work, but needs a functional test and removed model Related to the `model` module. cache Related to the `cache`-feature. gateway Related to the `gateway` module. examples Related to Serenity's examples. labels Nov 25, 2024
@GnomedDev GnomedDev mentioned this pull request Nov 25, 2024
Draft
@GnomedDev GnomedDev force-pushed the full-message-update branch from 281595a to 165c1ed Compare January 9, 2025 13:26
@github-actions github-actions bot added model Related to the `model` module. cache Related to the `cache`-feature. gateway Related to the `gateway` module. examples Related to Serenity's examples. labels Jan 9, 2025
@GnomedDev GnomedDev force-pushed the full-message-update branch from 165c1ed to 2a9073a Compare January 19, 2025 12:46
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Jan 19, 2025
@GnomedDev GnomedDev merged commit 31025c0 into serenity-rs:next Jan 19, 2025
24 checks passed
@GnomedDev GnomedDev deleted the full-message-update branch January 19, 2025 14:05
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Feb 1, 2025
@GnomedDev @mkrasnitski
Change MessageUpdateEvent to just contain a full Message (serenity-rs…
2621db2 
…#3061)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users cache Related to the `cache`-feature. enhancement An improvement to Serenity. examples Related to Serenity's examples. gateway Related to the `gateway` module. model Related to the `model` module. needs-testing A PR that should work, but needs a functional test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @arqunis