Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+ BUILD_SHARED_LIBS option #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

+ BUILD_SHARED_LIBS option #78

wants to merge 1 commit into from

Conversation

ponyatov
Copy link

for building binary w/o external .so dependency

@ponyatov
+ BUILD_SHARED_LIBS option
087ed89 
  for building binary w/o external .so dependency

Signed-off-by: Dmitry Ponyatov <[email protected]>
@sergei-mironov
Copy link
Owner

sergei-mironov commented Jan 22, 2025 •
edited
Loading

Hi @ponyatov . Im sorry for the long silence from my side! The change you are suggesting looks fine. Do you know what is the default value for the BUILD_SHARED option?
I have the following additional suggestions:

  1. Make sure that the default value is True to preserve the current behavior.
  2. Assert the absence of this option in the else branch of the BUILD_XKBSWITCH_LIB switch.
  3. Document the option in the Install section of the Readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ponyatov @sergei-mironov