fix: publish shared volumes

Temporary fix, do not check existence pv on the node. Signed-off-by: Serge Logvinov <[email protected]>
sergelogvinov · Jan 1, 2024 · a681b2b · a681b2b
1 parent 2a86bd7
commit a681b2b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/pkg/csi/controller.go b/pkg/csi/controller.go
@@ -329,9 +329,9 @@ func (d *ControllerService) ControllerPublishVolume(_ context.Context, request *
 		return nil, status.Error(codes.Internal, err.Error())
 	}
 
-	if vm.Node() != vol.Node() {
-		return nil, status.Error(codes.InvalidArgument, fmt.Sprintf("volume %s does not exist on the node %s", volumeID, nodeID))
-	}
+	// if vm.Node() != vol.Node() {
+	// 	return nil, status.Error(codes.InvalidArgument, fmt.Sprintf("volume %s does not exist on the node %s", volumeID, nodeID))
+	// }
 
 	options := map[string]string{
 		"backup":   "0",

diff --git a/pkg/csi/controller_test.go b/pkg/csi/controller_test.go
@@ -813,17 +813,17 @@ func (ts *csiTestSuite) TestControllerPublishVolumeError() {
 			},
 			expectedError: status.Error(codes.Internal, "proxmox cluster fake-region not found"),
 		},
-		{
-			msg: "WrongNode",
-			request: &proto.ControllerPublishVolumeRequest{
-				NodeId:           "cluster-1-node-2",
-				VolumeId:         "cluster-1/pve-1/local-lvm/vm-9999-pvc-123",
-				VolumeCapability: volcap,
-				VolumeContext:    volCtx,
-				Readonly:         true,
-			},
-			expectedError: status.Error(codes.InvalidArgument, "volume cluster-1/pve-1/local-lvm/vm-9999-pvc-123 does not exist on the node cluster-1-node-2"),
-		},
+		// {
+		// 	msg: "WrongNode",
+		// 	request: &proto.ControllerPublishVolumeRequest{
+		// 		NodeId:           "cluster-1-node-2",
+		// 		VolumeId:         "cluster-1/pve-1/local-lvm/vm-9999-pvc-123",
+		// 		VolumeCapability: volcap,
+		// 		VolumeContext:    volCtx,
+		// 		Readonly:         true,
+		// 	},
+		// 	expectedError: status.Error(codes.InvalidArgument, "volume cluster-1/pve-1/local-lvm/vm-9999-pvc-123 does not exist on the node cluster-1-node-2"),
+		// },
 		{
 			msg: "VolumeNotExist",
 			request: &proto.ControllerPublishVolumeRequest{