Use sha256 instead of md5 hashes for FIPS compliance #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sergeyksv I see that the Node7 build failed but it doesn't appear to be from my change. Can we still get this merged? |
|
@giancarlocosta You can always use your branch in references and gets module right from the GIT so this should be that urgent I hope. Fix is trivial but I need to check hot it behave with existing databases, probably some legacy of compatibility stuff will be required. |
|
Hello @giancarlocosta, did you end up figuring out how to solve this issue? We are also experiencing errors because of md5 hashing, when changing to sha256 it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a FIPS build of node (node in FIPS mode), I get errors because md5 hashing is not FIPS compliant. This PR will use sha256 hashing, which is FIPS compliant.