Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potlock sc #3

Merged
merged 12 commits into from
Aug 21, 2024

repo cleaup

a2f750a
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Potlock sc #3

repo cleaup
a2f750a
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Aug 21, 2024 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (2)

contracts/lottery-esdt/tests/lottery_esdt_blackbox.rs|143 col 5| warning: this function has too many arguments (10/7)
--> contracts/lottery-esdt/tests/lottery_esdt_blackbox.rs:143:5
|
143 | / fn start_lottery_error_params(&mut self, lottery_name_wrong: bool, token_identifier_wrong:u64, ticket_price_wrong:bool, opt_total_tick...
144 | | opt_max_entries_per_user_wrong: bool, opt_prize_distribution_wrong: bool, opt_burn_percentage_wrong: bool, error: ExpectError)
| |_______________________________________________________________________________________________________________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: #[warn(clippy::too_many_arguments)] on by default
contracts/lottery-esdt/tests/lottery_esdt_blackbox.rs|170 col 9| warning: unneeded late initialization
--> contracts/lottery-esdt/tests/lottery_esdt_blackbox.rs:170:9
|
170 | let token_identifier;
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
= note: #[warn(clippy::needless_late_init)] on by default
help: move the declaration token_identifier here and remove the assignments from the match arms
|
170 ~
171 |
172 ~ let token_identifier = match token_identifier_wrong{
173 ~ 1 => TestTokenIdentifier::new(""),
174 ~ 2 => TestTokenIdentifier::new("EGLD"),
175 ~ 3 => TOKEN_BURNABLE,
176 ~ _ => TOKEN_IDENTIFIER
177 ~ };
|