Skip to content

Commit

Permalink
fix: upgrade node-gyp (#50)
Browse files Browse the repository at this point in the history
* chore: upgrade node-gyp

- prebuildify-cross now supports python3 which should support node-gyp v9
- hopefully this fix base windows installs with no prebuilds
- additionally make the ls that happens on build fail cross platform

* lets see if windows-2019 does it
  • Loading branch information
reconbot authored Mar 4, 2022
1 parent 428f1d8 commit dd3c724
Show file tree
Hide file tree
Showing 4 changed files with 2,143 additions and 1,499 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ jobs:
command: prebuildify
args: --arch x64+arm64
- name: win32-x86
os: windows-latest
os: windows-2019
node: x86
command: prebuildify
- name: win32-x64
os: windows-latest
os: windows-2019
node: x64
command: prebuildify
- name: linux-x64
Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:
path: prebuilds/
if-no-files-found: error
- if: failure()
run: ls -la
run: npx shx ls -lA
release:
needs: prebuild
name: Release
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
# arch isn't used and we have no way to use it currently
- { os: macos-latest, arch: x64 }
- { os: ubuntu-latest, arch: x64 }
- { os: windows-latest, arch: x64 }
- { os: windows-2019, arch: x64 }
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
Expand Down
Loading

0 comments on commit dd3c724

Please sign in to comment.