Fix single character reads on windows #165
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a project using
@serialport/bindings-cpp
that works without issues on MacOS and Linux, but on windows every read fails withThe device I'm talking to has a binary protocol, and all exchanges begin with a single character write to the device, a single character response from the device, and then further, longer exchanges. The single character read always fails.
This is because
ReadThread
does a single character read usingReadFileEx
, and then, unconditionally reads "the rest of the data" usingReadFile
. But in the case of a single character read there is no "rest of the data". This pull request fixes it by checking for no more data before issuing theReadFile
.I don't know how to write a test that would fail without the fix.