allow to set rts/dtr/brk/cts/dsr seperately for windows #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we always pass true/false values into this function from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to set rts/dtr/brk/cts/dsr seperately for windows. It will always set a true/false value for these signals when using
setfunction, which will triggle multipleEscapeCommFunctionon windows. It will cause issues in some corner cases. For exmaple, in the esp32 flash logic, it needs to use rts and cts to control the IO signals, when using this library, the extraEscapeCommFunctionwill make the signal a little longer and it will fail to enter download mode. I've fixed it if we can set them seperately, please review the details in this PR. Thanks.