Skip to content

Commit

Permalink
chore: Upgrade to @serialport/bindings-cpp 13 (#2963)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: This upgrade brings node 20 as the lowest supported version - no other changes
  • Loading branch information
reconbot authored Dec 23, 2024
1 parent ef51844 commit a4ea1fe
Show file tree
Hide file tree
Showing 18 changed files with 78 additions and 70 deletions.
11 changes: 5 additions & 6 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4
- uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3
with:
node-version: 18
node-version: 20
- run: npm ci
- run: npm run lint
- run: npm run typecheck
Expand All @@ -20,12 +20,11 @@ jobs:
runs-on: ${{ matrix.config.os }}
strategy:
matrix:
node-version: [16.x, 18.x, 20.x]
node-version: [18.x, 20.x, 22.x]
config:
# arch isn't used and we have no way to use it currently
- { os: macos-latest, arch: x64 }
- { os: ubuntu-latest, arch: x64 }
- { os: windows-latest, arch: x64 }
- { os: macos-latest }
- { os: ubuntu-latest }
- { os: windows-latest }
steps:
- uses: actions/checkout@8ade135a41bc03ea155e62e844d188df1ea18608 # v4
- uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3
Expand Down
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.17.1
20.18.1
97 changes: 53 additions & 44 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"version": "0.0.0",
"description": "Node.js packages to access serial ports, process data from them and speak many protocols",
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"license": "MIT",
"scripts": {
Expand All @@ -26,7 +26,7 @@
"packages/*"
],
"devDependencies": {
"@serialport/bindings-cpp": "12.0.1",
"@serialport/bindings-cpp": "13.0.0",
"@tsconfig/node18": "18.2.1",
"@types/chai": "5.0.1",
"@types/chai-subset": "1.3.5",
Expand Down
4 changes: 2 additions & 2 deletions packages/list/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@
"build": "tsc --build tsconfig-build.json"
},
"dependencies": {
"@serialport/bindings-cpp": "12.0.1",
"@serialport/bindings-cpp": "13.0.0",
"commander": "11.0.0"
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.0.0"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/parser-byte-length/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"main": "./dist/index.js",
"types": "./dist/index.d.ts",
"engines": {
"node": ">=12.0.0"
"node": ">=20.0.0"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/parser-cctalk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"build": "tsc --build tsconfig-build.json"
},
"engines": {
"node": ">=12.0.0"
"node": ">=20.0.0"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/parser-delimiter/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"types": "./dist/index.d.ts",
"version": "12.0.0",
"engines": {
"node": ">=12.0.0"
"node": ">=20.0.0"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/parser-inter-byte-timeout/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"main": "./dist/index.js",
"types": "./dist/index.d.ts",
"engines": {
"node": ">=12.0.0"
"node": ">=20.0.0"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/parser-readline/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"@serialport/parser-delimiter": "12.0.0"
},
"engines": {
"node": ">=12.0.0"
"node": ">=20.0.0"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/parser-ready/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"types": "./dist/index.d.ts",
"version": "12.0.0",
"engines": {
"node": ">=12.0.0"
"node": ">=20.0.0"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/parser-regex/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"types": "./dist/index.d.ts",
"version": "12.0.0",
"engines": {
"node": ">=12.0.0"
"node": ">=20.0.0"
},
"publishConfig": {
"access": "public"
Expand Down
Loading

0 comments on commit a4ea1fe

Please sign in to comment.