Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open with O_CLOEXEC #130

Merged
merged 2 commits into from
Oct 30, 2023
Merged

open with O_CLOEXEC #130

merged 2 commits into from
Oct 30, 2023

Conversation

mrtnlrsn
Copy link

This fixes a problem with Tauri auto update: After updating the tauri application it is restarted, but the serial files were not closed, and therefore the application could not open them again.

With this flag the files are closed when executing execve() to start the new application instance.

Change-Id: I102ba33411135a8e89e3203f9dad910d385feeee

This fixes a problem with Tauri auto update: After updating the tauri
application it is restarted, but the serial files were not closed, and
therefore the application could not open them again.

With this flag the files are closed when executing `execve()` to start
the new application instance.

Change-Id: I102ba33411135a8e89e3203f9dad910d385feeee
Copy link
Contributor

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Could you add an entry to the changelog about this?

Change-Id: Ibbfa25312f05999f184b6986bc5c421e154a1e0e
Copy link
Contributor

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eldruin eldruin merged commit 6c3ddc0 into serialport:main Oct 30, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants