Fix serial number reporting on Windows for some devices

[xobs]

Some devices have their serial numbers misreported. For example, the BMP device USB\VID_1D50&PID_6018&MI_02\6&A694CA9&0&0000 gets a reported serial number of 6 rather than A694CA9.

Fix this and update the testcase.

[xobs]

Additionally, several clippy lints were fixed as a result of looking over this code.

[eldruin]

Nice, thank you!
Could you add a short entry to the changelog as well?

[xobs]

I'm actually not sure about the validity of this approach.

For example, on my system, the serial number shows up as 3aab607b. That's because my hwid is 8&3aab607b&0&0000. However, my actual serial number is 97B6DC14.

It's possible to get the serial number by trimming &MI_00 from the port, then looking for a matching ParentIdPrefix value that matches the hwid.

Is there still interest in this patch if it returns "a" serial number rather than "the" serial number?

[eldruin]

I see. I am not sure myself. Maybe somebody else can weigh in?

[danielstuart14]

Yes! Even if it doesn't return "the" serial number, it still is a lot better than before.
With this PR, I can distinguish between two identical devices (each with two CDC endpoints), which I couldn't do before.

Before:

After:

[xobs]

Sounds good. I've updated CHANGELOG.md as requested.

[eldruin]

Great, thank you!