Use maintained sys crates for CoreFoundation and IOKit #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This catches two birds with one stone: The function is already present in the released core-foundation-sys 0.8.4. CFDictionaryGetValue might return NULL which according to https://github.com/opensource-apple/CF/blob/3cc41a76b1491f50813e28a4ec09954ffa359e6f/CFRuntime.c#L500 does not seem to be a valid input to CFGetTypeID.
eldruin
approved these changes
Nov 21, 2023
sirhcel
added a commit
to sirhcel/serialport-rs
that referenced
this pull request
Nov 24, 2023
This got fixed with serialport#136 but the exemption for the mach crate survived but is no longer needed. Keeping it in place would prevent us from getting notified from CI in case this dependency would be reintroduced by accident.
eldruin
pushed a commit
that referenced
this pull request
Dec 8, 2023
This got fixed with #136 but the exemption for the mach crate survived but is no longer needed. Keeping it in place would prevent us from getting notified from CI in case this dependency would be reintroduced by accident.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CFDictionaryGetandCFGetTypeIDNULLpointer which does not seem to be accepted byCFGetTypeIDby switching toCFDictionaryGetIfPresentCFDictionaryGetIfPresentalso allow us to use the already released versions of core-foundation-sys and io-kit and not wait for upcomming releases (like Publish a new version of core-foundation-sys servo/core-foundation-rs#645)