Add conversions between DataBits, StopBits and their numeric representation #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldruin
reviewed
Feb 15, 2024
DNedic
force-pushed
the
add_bitcount_numeric_conversions
branch
from
b634892 to
c3cf94f
Compare
|
@eldruin Thanks for the feedback, PTAL |
DNedic
force-pushed
the
add_bitcount_numeric_conversions
branch
from
c3cf94f to
881af0a
Compare
eldruin
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
TryFromandFromtraits foru8andDataBits/StopBitsrespectively, can be useful for niche uses.For instance, I had written an
RFC2217server implementation, and the lack of these required implementing all of these myself.