Fix intermittent failures with CI build and clean up #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were recently a lot of hiccups with installing rustup for Windows in CI and the previously used actions from actions-rs seem to be no longer maintained. Following the discussion in rust-lang/rustup#3409, this is one way to go.
sirhcel
force-pushed
the
ci-toolchain-dtolnay
branch
from
ba62de6
to
484f602
Compare
I've seen warnings about the removal of the key vulnerability for advisories with the reference to EmbarkStudios/cargo-deny#611. This indicates that the default behavior is about to change. Let's switch to the new defaults now.
sirhcel
force-pushed
the
ci-toolchain-dtolnay
branch
from
484f602
to
8e023a2
Compare
We're getting deprecation warnings for GitHubs save-state command when using v1 of this action. Bumping this action to the latest version irons this out.
sirhcel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were recently a lot of hiccups with installing rustup for Windows in CI. For example here. This PR switches to a current and actively maintained action for installing the Rust toolchain.
The previous issues were intermittent and could be overcome by trying several times. But let's have a less dicey way for running CI checks. This PR also includes cleaning up warnings from issues with outdated configuration and actions.