Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.5.1 #217

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Release 4.5.1 #217

merged 3 commits into from
Sep 20, 2024

Conversation

sirhcel
Copy link
Contributor

@sirhcel sirhcel commented Sep 20, 2024

Writing unrequested debug output to stdout (#216) is bad manners for a library. Let's iron this out with h patch release.

@sirhcel sirhcel requested a review from eldruin September 20, 2024 11:24
Copy link
Contributor

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@eldruin eldruin merged commit eca70a7 into serialport:main Sep 20, 2024
29 of 30 checks passed
@sirhcel
Copy link
Contributor Author

sirhcel commented Sep 20, 2024

Thank you very much for the swift review @eldruin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants