Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip attempts to set baud rate of 0 via ioctl (macos) #58

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

mf-dhadley
Copy link
Contributor

On macOS, attempts to set the baud rate of pseudo terminals via normal
ioctl apis appears to be problematic. To support users targeting these
pseudo terminals, this commit adds the ability to use a baud_rate of 0
to skip the attempt altogether.

relates to #22 & #49

On macOS, attempts to set the baud rate of pseudo terminals via normal
ioctl apis appears to be problematic. To support users targeting these
pseudo terminals, this commit adds the ability to use a `baud_rate` of 0
to skip the attempt altogether.
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix/workaround, and extra thanks for documenting and testing it!

@jessebraham jessebraham merged commit b54264b into serialport:main Jul 7, 2022
@tmbull tmbull mentioned this pull request Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants