Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 8.0.0 #596

Merged
merged 17 commits into from
Nov 5, 2024
Merged

Release 8.0.0 #596

merged 17 commits into from
Nov 5, 2024

Conversation

ckadluba
Copy link
Member

@ckadluba ckadluba commented Nov 4, 2024

  • Updated to .NET 8
  • Updated nearly all dependencies
  • Improved build script (build samples, fail on vulns, ...)
  • Removed some obsolete vulnerability fix dependencies
  • Fixed missing dependency in AppConfigDemo sample

* Do not use loops since we only have one project for main sink, one for tests and one for perftests.
* Use try-finally blocks to pop back to caller's initial dir on errors.
* Fail the build if there were nuget restore errors (e.g. due to known vulns).
* build also sample projects on PR (skip them in release.yml and perftests.yml).
In the test project the assembly System.Transactions was referenced also for .NET (Core) which leads to a warning with the update to .NET 8. Now we reference it only for the .NET Framework targets.
Necessary to have .NET 4.6.2 reference assemblies for building and analyzing AppConfigDemo.
System.Formats.Asn1 and System.Private.Uri were only added to fix a vulnerability caused by old versions referenced transitively. After the update to .NET 8 and update of all dependencies they can now be removed again.
System.Text.Json was only added to fix a vulnerability caused by an old version referenced transitively. After the update to .NET 8 and update of all dependencies it can now be removed again.
@ckadluba ckadluba requested a review from jonorossi November 4, 2024 11:05
@ckadluba
Copy link
Member Author

ckadluba commented Nov 4, 2024

Finishing the MSSQL sink 8.0.0 release with an update to .NET 8. @jonorossi or @cancakar35 if you find some minutes to take a brief look over the changes, I would highly appreciate it. :)

Copy link
Member

@jonorossi jonorossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ckadluba
Copy link
Member Author

ckadluba commented Nov 5, 2024

Thank you mister. ☺️

@ckadluba ckadluba merged commit 2d9f79d into main Nov 5, 2024
11 checks passed
@cancakar35
Copy link
Member

It's a little bit late, but looks good. Even works on legacy web forms app without any issue 😅

@ckadluba
Copy link
Member Author

ckadluba commented Nov 5, 2024

It's a little bit late, but looks good. Even works on legacy web forms app without any issue 😅

Thank you very much fot testing. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants