Release 8.1.0 #604
Merged
Release 8.1.0 #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ckadluba
commented
Dec 6, 2024
ckadluba
commented
- Implemented Custom Columns where the Property Name contains a dot is not populated. #542: Column option ResolveHierarchicalPropertyName to force non-hierarchical handling
- Removed unnecessary exception handlers and let Serilog Core do the SelfLog()
- Refactoring and performance optimizations in batched and audit sink
- Create perftest result on release
- Updated issue template
- Updated editorconfig
- Added specific documentation about when SQL SELECT permission is not required
* Updated version to 8.0.1 * Set PackageValidationBaselineVersion to 8.0.0 and EnablePackageValidation to true.
Post release 8.0.0 housekeeping
SELECT permissions are not required in all cases.
Upload performance test results as an artifact in release.yml
Refactoring * Removed DataTableCreator from class MsSqlServerSink. Pushed it down to SqlBulkBatchWriter. This also made it possible to remove reference to System.Data in MsSqlServerSink. * Removed DataTableCreator from SinkDependencies. * Removed IBulkBatchWriter interface from SqlInsertStatementWriter. MSSqlServerSink class now has separate instances of ISqlBulkBatchWriter and ISqlLogEventWriter and chooses which one to use based on sink option `UseSqlBulkCopy`. * Added new class SqlCommandFactory with interface ISqlCommandFactory Performance optimizations in batched sink * Generate schema and table string only once and do not use string.Format(). * Do not cast on each column of each log event. Performance optimizations in audit sink * Render INSERT string only once and not for each log event since it will not change between log events. * Do not create a separate SqlCommand for each log event. Reuse the same and set only new SqlConnection, CommandText and parameters for each log event. Added new tests and adapted existing ones.
Refactoring and Performance Optimizations
Parallel execution of DB tests on the one single local DB led to concurrency problems. Therefore the script now runs tests for each supported target framework in a separate call, avoiding parallelism of the DB tests.
Issue #542
Added unit and integration tests for new functionality. Issue #542
Use new column option `ResolveHierarchicalPropertyName` in WorkerServiceDemo sample app. Issue #542
Documented new column option `ResolveHierarchicalPropertyName` in README.md. Issue #542
…props Implemented #542: Column option ResolveHierarchicalPropertyName to force non-hierarchical handling
The sink had exceptions handlers when log events could not be written. Those handlers wrote an error message using Serilog's SelfLog() facility. This is now done by the Serilog Core when a sink's Emit() and EmitBatchAsync() methods throw an exception. This is why can remove our handlers, let exceptions propagate and Serilog Core do the work.
Remove obsolete exception handlers
A Dispose() call for _sqlBulkBatchWriter was missing in MSSqlServerSink class.
Fixed: dispose SqlBulkBatchWriter in sink
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.