[INT-224] Update for GHC 9.8 compatibility #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lierdakil
force-pushed
the
lierdakil/chore-update-ghc-9.8
branch
6 times, most recently
from
5d2a27f to
6767d2c
Compare
Problem: GHC 9.8 complains about missing role annotations. Solution: Add them.
Problem: GHC 9.8 complains about orphan type family instances in Bindings.chs. Solution: Moving definitions to the chs file is inconvenient, so allow orphans instead, this is runtime-safe anyway.
Problem: hex-text isn't updated for GHC 9.8 Solution: use base16-bytestring directly.
Problem: dependency constraints are too tight for GHC 9.8. Solution: relax them.
Problem: resolver is somewhat outdated Solution: bump it to latest lts.
Problem: tested-with doesn't mention GHC 9.8.1 Solution: add it.
Problem: GHC 9.4 is still the recommended compiler, we want to test with it. However, lts is on GHC 9.6 already. Solution: add lts-21 to the CI config.
Problem: lower bound on `base` is too slack, it allows GHC 9.0, which we don't test with. Solution: bump lower base bound to match GHC 9.4.
Problem: c-sources now doesn't admit assembly files since cabal 3.10, and stack 2.13 follows that. The field asm-sources is only available since Cabal format version 3, and hpack doesn't support that. Solution: liberally use verbatim in package.yaml
lierdakil
force-pushed
the
lierdakil/chore-update-ghc-9.8
branch
from
6767d2c to
ba54103
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: stackage nightly is on GHC 9.8.
Solution: update to support GHC 9.8
Since this requires a new release, also bump blst version to latest release.
Related issue(s)
✅ Checklist for your Pull Request
Related changes (conditional)
Tests
silently reappearing again.
Documentation
I checked whether I should update the docs and did so if necessary:
I added an entry to the changelog if my changes are visible to the users
and
provided a migration guide for breaking changes if possible
Stylistic guide (mandatory)