Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

fix: fix stdio and tons of windows issues #684

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: fix stdio and tons of windows issues #684

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
22ffa6b
fix: fix stdio and tons of windows issues
jeanbmar Mar 3, 2022
6b3ae49
feat: always output stdout and stderr
jeanbmar Mar 3, 2022
7b26205
Merge branch 'master' into patch-1
jeanbmar Mar 8, 2022
345fb7e
style: match prettier requirements
jeanbmar Mar 8, 2022
9786f1e
Merge branch 'master' into patch-1
jeanbmar Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/pip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,10 +376,10 @@ async function installRequirements(targetFolder, pluginInstance) {
break;
}

let spawnArgs = { shell: true };
if (process.env.SLS_DEBUG) {
spawnArgs.stdio = 'inherit';
}
const spawnArgs = {
shell: true,
stdio: 'inherit',
};
let mainCmds = [];
if (dockerCmd.length) {
dockerCmd.push(...mergeCommands(pipCmds));
Expand All @@ -397,7 +397,7 @@ async function installRequirements(targetFolder, pluginInstance) {

for (const [cmd, ...args] of mainCmds) {
try {
await spawn(cmd, args);
await spawn(cmd, args, spawnArgs);
} catch (e) {
if (
e.stderrBuffer &&
Expand Down