Add option for copying dependencies instead of creating a link #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgrzesik
suggested changes
Mar 8, 2022
There was a problem hiding this comment.
Thanks @Psycholive - I have some comments, it also would be good to cover that functionality with a test case
README.md
Outdated
| ```yaml | ||
| custom: | ||
| pythonRequirements: | ||
| useFinalCopy: true |
There was a problem hiding this comment.
I'm not sure if this property name is a great choice here - it doesn't really convey the meaning in my opinion - maybe we could use something more descriptive? Like useSymlinks: false or something along those lines? What do you think?
There was a problem hiding this comment.
Property naming is always a difficult task :) Why not useSymlinks indeed.
README.md
Outdated
|
|
||
| Before final packaging, a link is created in .serverless folder for python dependencies. | ||
| If it is not possible to create a symbolic link, dependencies can be copied instead of linked | ||
| whith the foloowing option: |
added 3 commits
March 8, 2022 14:49
|
Hey @Psycholive - sorry for not responding for a long time. Do you still have time to finalize this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a case where a windows folder containing sources is mounted in a linux VM and therefore symlinks cannot be created in .serverless folder.
This PR add a new option to copy dependencies in .serverless folder instead of creating a symlink. It is less beautiful and quick but it is the only option I see in my case.
It is possible to include this option in next release?