Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retain to layer options #758

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add retain to layer options #758

wants to merge 2 commits into from

Conversation

naoyasugita
Copy link

@naoyasugita naoyasugita commented Feb 12, 2023 •
edited
Loading

This change allows use of retain option with the layers.

Should resolve:
#557
#697

@naoyasugita naoyasugita changed the title Enable retain option with layer Add retain to layer options Feb 12, 2023
@jbsilva
Copy link

jbsilva commented Aug 23, 2023

This looks correct and useful. I hope it gets merged.

pgrzesik
pgrzesik reviewed Oct 22, 2023
View reviewed changes
Copy link
Contributor

@pgrzesik pgrzesik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry for the delay and thanks for the proposal. Do you think we could have this covered by the unit test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgrzesik pgrzesik pgrzesik left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naoyasugita @jbsilva @pgrzesik