-
Notifications
You must be signed in to change notification settings - Fork 39
Enabled label management when creating or editing a workflow #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…r editing workflows Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
c654349
to
0d7af28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables label and annotation management when creating or editing workflows in the Synapse Dashboard. It replaces the simplified operator selection with comprehensive label/annotation management through a new dictionary editor component.
- Introduces a
DictionaryEditor
component for managing key-value pairs (labels and annotations) - Refactors workflow creation and instance creation to use labels/annotations instead of operator strings
- Updates UI layout with improved CSS classes and styling for better organization
Reviewed Changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
src/dashboard/Synapse.Dashboard/wwwroot/css/table.scss |
Adds utility CSS for table column width fitting |
src/dashboard/Synapse.Dashboard/wwwroot/css/app.scss |
Adds flex utilities and updates problem display styling |
src/dashboard/Synapse.Dashboard/Pages/Workflows/Details/View.razor |
Updates workflow instance creation calls to pass labels/annotations |
src/dashboard/Synapse.Dashboard/Pages/Workflows/Details/Store.cs |
Refactors instance creation to use labels/annotations instead of operator string |
src/dashboard/Synapse.Dashboard/Pages/Workflows/Create/View.razor |
Integrates dictionary editor for labels/annotations in workflow creation |
src/dashboard/Synapse.Dashboard/Pages/Workflows/Create/Store.cs |
Adds label/annotation management methods and updates save logic |
src/dashboard/Synapse.Dashboard/Pages/Workflows/Create/State.cs |
Adds Labels and Annotations properties, removes Operator property |
src/dashboard/Synapse.Dashboard/Components/DictionaryEditor/DictionaryEditor.razor |
New reusable component for editing key-value dictionaries |
src/dashboard/Synapse.Dashboard/Components/CreateWorkflowInstanceDialog/CreateWorkflowInstanceParameters.cs |
Replaces Operator property with Labels and Annotations |
src/dashboard/Synapse.Dashboard/Components/CreateWorkflowInstanceDialog/CreateWorkflowInstanceDialog.razor |
Integrates dictionary editor for instance creation dialog |
Comments suppressed due to low confidence (2)
src/dashboard/Synapse.Dashboard/Components/DictionaryEditor/DictionaryEditor.razor:64
- The method name 'AddLabel' is misleading since this component is a generic dictionary editor that can handle both labels and annotations. Consider renaming to 'AddEntry' to match the component's generic purpose.
private void AddLabel()
src/dashboard/Synapse.Dashboard/Components/DictionaryEditor/DictionaryEditor.razor:76
- The method name 'RemoveLabel' is misleading since this component is a generic dictionary editor that can handle both labels and annotations. Consider renaming to 'RemoveEntry' to match the component's generic purpose.
private void RemoveLabel(string key)
src/dashboard/Synapse.Dashboard/Pages/Workflows/Create/View.razor
Outdated
Show resolved
Hide resolved
src/dashboard/Synapse.Dashboard/Pages/Workflows/Create/View.razor
Outdated
Show resolved
Hide resolved
Signed-off-by: Jean-Baptiste Bianchi <[email protected]>
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Adds the ability to add/remove labels from a workflow.
Special notes for reviewers:
Additional information (if needed):