Update the CanGc in Web API Hack #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zazabap <[email protected]>
zazabap
force-pushed
the
feature/update-CanGc
branch
from
14a4f3f to
f00ab94
Compare
jdm
reviewed
Aug 20, 2025
| - `GlobalScope`: can be obtained using `self.global()` on a `dom_struct`, or `GlobalScope::from_safe_context` | ||
| - `InRealm`: can be obtained as an argument to the generated trait method, using [this configuration file](https://github.com/servo/servo/blob/4a5ff01e060293721d10289ec56dbd4c58a0969e/components/script_bindings/codegen/Bindings.conf) | ||
| - `CanGc`: same as for `InRealm`. | ||
| - `CanGc`: same as for `InRealm` using the same configuration file. When working with `RefCall::borrow_mut` int methods that take a `CanGc` argument, please avoid mutable borrow hazard, using the implementation similar to [this example](https://github.com/servo/servo/blob/f19b2f6e848ad2b4b5fde8969958e37e76844faa/components/script/dom/response.rs#L455). |
There was a problem hiding this comment.
I think this requires more detail in a separate page that would be linked from this. What I'm imagining is:
- What does a CanGc argument mean?
- If I am calling a method that takes a CanGc argument, where do I get one?
- Risks of CanGc with RefCell::borrow_mut
- Patterns for avoiding mutable borrow hazards
I'm perfectly happy to write this, but let me know if you want to try!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by the issue in servo repository servo/servo#38105
Update the method to deal with mutable borrow hazard when using
CanGcandRefCell::borrow_mut