Fix CoreText font width to CSS font stretch conversion #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm confused why CI isn't starting. |
I think the workflow just needs to be approved since @ColdPaleLight isn't in the contributors group. I've gone ahead and approved the workflow run. |
|
Bleach, the formatting on our main branch is busted. Would you mind pulling 99e9918 into your branch to allow CI to pass? |
Previous mapping was incorrect, using [-1, 1] to [0, 8]. Based on the values ranging from 'kCTFontWidthExtraCompressed' (-0.4) to 'kCTFontWidthUltraExpanded' (0.4), the corrected conversion maps CoreText font width values from [-0.4, 0.4] to [0, 8]
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue: #258
Previous mapping was incorrect, using [-1, 1] to [0, 8]. Based on the values ranging from 'kCTFontWidthExtraCompressed' (-0.4) to 'kCTFontWidthUltraExpanded' (0.4), the corrected conversion maps CoreText font width values from [-0.4, 0.4] to [0, 8]