Remove rustc-test dependency #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't actually used by any code in the crate.
This doesn't distribute the individual tests across the build-in harness, hurting parallelism and process isolation. On the other hand it's a minimal change to port off the rustc-test dependency which hasn't been actively maintained and currently doesn't compile.
Move the custom test runner into its own `util::runner` module and use it instead of rustc_test for the other test files. This allows `cargo test` to complete under rust 1.77.1.
This is no longer available since the depdendency has been removed.
|
force-pushed a rebase with fixes for ci failures. |
Closed
|
Recommend to move to https://github.com/LukasKalbertodt/libtest-mimic -- currently hacking around the testsuite and the DX is really not good. |
untitaker
added a commit
to untitaker/html5ever
that referenced
this pull request
Oct 28, 2024
servo#528 regressed the DX significantly, add a lighter and more maintained test harness to get basic functionality like "run one test" back.
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
* Add libtest-mimic #528 regressed the DX significantly, add a lighter and more maintained test harness to get basic functionality like "run one test" back. * appease clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rustc-testcrate v0.3.1 depends on rustc-serialize v0.3 which is unmaintained and unfortunately no longer compiles under rust 1.77.1.Remove this crate in favour of a trivial test runner. This drops many nice features of the rustc test runner like parallelization, colour output, per-subtest command line selection support, and output capture on failure. On the other hand, it reduces the maintenance surface and unbreaks the build.
Resolves #526