Test EGL and build_dlls #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagudev
commented
Oct 15, 2023
| @@ -23,5 +23,5 @@ gl_generator = { version = "0.14", optional = true } | |||
| walkdir = "2" | |||
|
|
|||
| [features] | |||
| egl = ["gl_generator"] # Only does anything on Windows | |||
| build_dlls = ["egl", "gl_generator"] | |||
There was a problem hiding this comment.
This is because because no build_dlls code directly depends on gl_generator and it gets included anyway because build_dlls depends on egl.
jdm
approved these changes
Oct 15, 2023
sagudev
force-pushed
the
more-ci
branch
2 times, most recently
from
7a9c1bd to
37295f2
Compare
test_egl_dll_linkage needs build_dlls
|
It seems that mq wants cc @mrobinson |
This should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we tested only for build_dlls (that contains EGL, but it's better to test all configurations)