Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set compiler argument '-march:SSE2' only if target is Windows #78

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Set compiler argument '-march:SSE2' only if target is Windows #78

merged 1 commit into from
Aug 7, 2024

Conversation

dpino
Copy link
Contributor

@dpino dpino commented May 7, 2024

When building mozangle on Linux, there are many warning message like this printed on stdout:

warning: [email protected]: clang: warning: argument unused during compilation: '-arch:SSE2' [-Wunused-command-line-argument]

The reason is compiler argument -arch:SSE2 is only valid for MSVC.

Only add compiler argument -arch:SSE2 is target platform is Windows.

mrobinson
mrobinson requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpino Apologies for the very late review! I was not subscribed to notifications on this repository.

build.rs Outdated Show resolved Hide resolved
@dpino dpino force-pushed the remove-warning-argument-not-used-sse2 branch from b390587 to 477d528 Compare August 7, 2024 09:31
sagudev
sagudev reviewed Aug 7, 2024
View reviewed changes
build.rs Outdated Show resolved Hide resolved
mrobinson
mrobinson requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use is_like_msvc when determining what argument to pass. Thanks!

@dpino dpino force-pushed the remove-warning-argument-not-used-sse2 branch from 477d528 to 3bb502a Compare August 7, 2024 10:10
@mrobinson mrobinson added this pull request to the merge queue Aug 7, 2024
Merged via the queue into servo:main with commit f9d5dd4 Aug 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagudev sagudev sagudev left review comments

@mrobinson mrobinson mrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpino @mrobinson @sagudev