-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLVM linking #9
LLVM linking #9
Conversation
It seems like that could impact our builders. Seems like a sensible solution, I guess. Thanks for looking into it! :) |
We'd need to ask @glennw why he added |
I can't recall the exact reason for that flag - I think I was having issues with dynamic library paths on mac without it. The actual ideal solution would be to disable LLVM from the build altogether, if there is a flag for that? For our test scenario, we specifically want to use the softpipe driver, and not the llvmpipe driver. This is because when running 10,000+ simple tests (like our CI does), the shader compile time with llvmpipe dominates, and so the tests actually run much faster with softpipe :) Now that we use softpipe driver, it might be safe to remove this flag anyway, since we select the softpipe driver at startup time. |
If there's no flag to disable llvmpipe from the build, let me know and I'll test this locally on mac + linux, and merge it if all works ok. |
@glennw Who will know that? |
You could try configuring osmesa with --enable-gallium-llvm=no per https://github.com/servo/osmesa-src/blob/master/mesa-12.0.1/configure.ac#L2082 . |
I've tested changes in configure.ac: But deleting |
Will the patch be merged? |
@mskrzypkows I'll test with your patch on each platform next week. There was a specific reason for having that flag, so I'll need to test again on each platform before removing it. If all goes well, I'll merge it. |
any chance of this being merged? I'm having issues building on OSX due to a strange ncurses linker error too. |
fix #7
I'm not sure if it's proper solution for #7 but it solves build break on my Ubuntu 14.04.