Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLVM linking #9

Closed
wants to merge 1 commit into from
Closed

LLVM linking #9

wants to merge 1 commit into from

Conversation

mskrzypkows
Copy link

fix #7

I'm not sure if it's proper solution for #7 but it solves build break on my Ubuntu 14.04.

@emilio
Copy link
Member

emilio commented Oct 12, 2016

r? @larsbergstrom

It seems like that could impact our builders. Seems like a sensible solution, I guess. Thanks for looking into it! :)

@larsbergstrom
Copy link
Contributor

We'd need to ask @glennw why he added --disabled-shared-llvm-libs in the first place. I don't have a big opinion myself on the build machines for whether we link against an existing LLVM installation or build our own, though I suspect that linking against the existing one would also help me with my sadly-stalled #3 :-)

@glennw
Copy link
Member

glennw commented Oct 12, 2016

I can't recall the exact reason for that flag - I think I was having issues with dynamic library paths on mac without it. The actual ideal solution would be to disable LLVM from the build altogether, if there is a flag for that?

For our test scenario, we specifically want to use the softpipe driver, and not the llvmpipe driver. This is because when running 10,000+ simple tests (like our CI does), the shader compile time with llvmpipe dominates, and so the tests actually run much faster with softpipe :)

Now that we use softpipe driver, it might be safe to remove this flag anyway, since we select the softpipe driver at startup time.

@glennw
Copy link
Member

glennw commented Oct 12, 2016

If there's no flag to disable llvmpipe from the build, let me know and I'll test this locally on mac + linux, and merge it if all works ok.

@mskrzypkows
Copy link
Author

If there's no flag to disable llvmpipe from the build, let me know

@glennw Who will know that?

@jdm
Copy link
Member

jdm commented Oct 19, 2016

You could try configuring osmesa with --enable-gallium-llvm=no per https://github.com/servo/osmesa-src/blob/master/mesa-12.0.1/configure.ac#L2082 .

@mskrzypkows
Copy link
Author

mskrzypkows commented Oct 26, 2016

I've tested changes in configure.ac:
[enable_gallium_llvm=no]
and second try with:
[enable_llvm_shared_libs=no]
none of above code samples works.

But deleting .arg("--enable-gallium-osmesa") from build.rs and bringing back .arg("--disable-llvm-shared-libs") makes building OK.

@mskrzypkows
Copy link
Author

Will the patch be merged?

@glennw
Copy link
Member

glennw commented Nov 4, 2016

@mskrzypkows I'll test with your patch on each platform next week. There was a specific reason for having that flag, so I'll need to test again on each platform before removing it. If all goes well, I'll merge it.

@emuplz
Copy link

emuplz commented Dec 5, 2016

any chance of this being merged? I'm having issues building on OSX due to a strange ncurses linker error too.

@emilio emilio mentioned this pull request Dec 14, 2016
@emilio emilio closed this in #15 Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

llvm linking build break
6 participants