parser: Implement recent syntax spec change to avoid parsing custom properties that look like selectors as rules. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed upstream by @zrhoffman (this incorporates their suggested changes) |
emilio
force-pushed
the
custom-props-nesting
branch
2 times, most recently
from
76180ef to
9263f8c
Compare
…roperties that look like selectors. This implements the: > If the first two non-<whitespace-token> values of rule’s prelude are > an <ident-token> whose value starts with "--" followed by a > <colon-token>, then... From https://drafts.csswg.org/css-syntax/#consume-qualified-rule Mozilla Bug: 1884879 Differential Revision: https://phabricator.services.mozilla.com/D207796
emilio
force-pushed
the
custom-props-nesting
branch
from
9263f8c to
5dc6d91
Compare
zrhoffman
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the:
From https://drafts.csswg.org/css-syntax/#consume-qualified-rule
Mozilla Bug: 1884879
Differential Revision: https://phabricator.services.mozilla.com/D207796