webdriver: Report error instead of panic for invalid WebElement&ShadowRoot reference
#39976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Euclid <[email protected]>
Signed-off-by: Euclid <[email protected]>
servo-highfive
added
the
S-awaiting-review
Member
Author
|
Spec update here. |
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#55527) with upstreamable changes. |
Collaborator
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#55527) title and body. |
servo-highfive
added
S-needs-code-changes
Member
Author
You wrongly pressed "Request changes" tho. |
mrobinson
approved these changes
Oct 18, 2025
Member
Apologies. I've fixed that now. 🤦 |
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that the reference of
WebElementandShadowRootin the request is not String. Instead of panic, we should return "invalid argument" same as theWebWindowandWebFrame.Testing: Added 4 new subtests. There was only tests for
WebWindowandWebFramesomehow.