Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a GitHub Actions main workflow and fix the build #9

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Add a GitHub Actions main workflow and fix the build #9

merged 1 commit into from
Mar 4, 2024

Conversation

mrobinson
Copy link
Member

@mrobinson mrobinson commented Feb 28, 2024 •
edited
Loading

Fixes #12.

@mrobinson mrobinson requested a review from delan February 29, 2024 08:38
@mrobinson mrobinson changed the base branch from 2023-06-14 to 2023-07-23 February 29, 2024 08:38
@mrobinson mrobinson force-pushed the add-ci-and-fix-build branch from 27b2f03 to 4522ec5 Compare February 29, 2024 08:39
delan
delan reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@delan delan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s merge this once we sort out the main branch situation, I’ll have a patch for that up soon. In the meantime, don’t forget to check in the workflow.yml :)

@delan delan changed the base branch from upgrade to main March 1, 2024 09:59
@mrobinson mrobinson force-pushed the add-ci-and-fix-build branch 2 times, most recently from aacdebd to 61ae069 Compare March 1, 2024 12:31
@mrobinson
Copy link
Member Author

Whoops. This should be ready to go now. Checks should be showing up as passing below.

@mrobinson mrobinson force-pushed the add-ci-and-fix-build branch from 61ae069 to 2fd16fd Compare March 4, 2024 10:30
@mrobinson mrobinson mentioned this pull request Mar 4, 2024
Closed
@mrobinson mrobinson requested a review from delan March 4, 2024 11:59
mukilan
mukilan reviewed Mar 4, 2024
View reviewed changes
.github/workflows/main.yml Outdated
env:
RUST_BACKTRACE: 1

build_result:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the other jobs use the dash as a separator but here we use the underscore.

@mrobinson mrobinson force-pushed the add-ci-and-fix-build branch from 2fd16fd to e3ba9db Compare March 4, 2024 13:33
@mrobinson mrobinson force-pushed the add-ci-and-fix-build branch from e3ba9db to ed2802d Compare March 4, 2024 13:36
@mrobinson mrobinson merged commit f587a05 into main Mar 4, 2024
3 checks passed
@mrobinson mrobinson deleted the add-ci-and-fix-build branch March 4, 2024 13:38
Loirooriol pushed a commit to Loirooriol/stylo that referenced this pull request Mar 10, 2024
@mrobinson @Loirooriol
Add a GitHub Actions main workflow and fix the build (servo#9)
e698aab
Loirooriol pushed a commit that referenced this pull request Mar 29, 2024
@mrobinson @Loirooriol
Add a GitHub Actions main workflow and fix the build (#9)
eaf0a50
Loirooriol pushed a commit that referenced this pull request Apr 9, 2024
@mrobinson @Loirooriol
Add a GitHub Actions main workflow and fix the build (#9)
d8160bf
Loirooriol pushed a commit that referenced this pull request Apr 13, 2024
@mrobinson @Loirooriol
Add a GitHub Actions main workflow and fix the build (#9)
753635d
Loirooriol pushed a commit that referenced this pull request Apr 15, 2024
@mrobinson @Loirooriol
Add a GitHub Actions main workflow and fix the build (#9)
5f2f6fc
Loirooriol pushed a commit that referenced this pull request Apr 22, 2024
@mrobinson @Loirooriol
Add a GitHub Actions main workflow and fix the build (#9)
dab56c2
Loirooriol pushed a commit that referenced this pull request May 21, 2024
@mrobinson @Loirooriol
Add a GitHub Actions main workflow and fix the build (#9)
d67b3d9
Loirooriol pushed a commit that referenced this pull request Jun 11, 2024
@mrobinson @Loirooriol
Add a GitHub Actions main workflow and fix the build (#9)
787441f
Loirooriol pushed a commit that referenced this pull request Jun 24, 2024
@mrobinson @Loirooriol
Add a GitHub Actions main workflow and fix the build (#9)
b72068b
Loirooriol pushed a commit that referenced this pull request Jun 24, 2024
@mrobinson @Loirooriol
Add a GitHub Actions main workflow and fix the build (#9)
88c15f5
mrobinson added a commit that referenced this pull request Jun 25, 2024
@mrobinson
Add a GitHub Actions main workflow and fix the build (#9)
87b335b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukilan mukilan mukilan approved these changes

@delan delan Awaiting requested review from delan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Improper dependencies in Stylo
3 participants
@mrobinson @mukilan @delan