forked from oxen-io/libsession-util
-
Notifications
You must be signed in to change notification settings - Fork 4
Release 1.2.0 #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mpretty-cyro
wants to merge
665
commits into
stable
Choose a base branch
from
dev
base: stable
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release 1.2.0 #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: allow config wrappers to be extended
fix: make FULL_URL_MAX_LENGTH a constexpr and not such static const
• Fixed an issue causing the tests to crash • Fixed an issue where the handle_errors function may not correctly report a timeout • Removed hacky attempts to fix test crash • Removed some redundant code
• Fixed an issue where refreshing the snode cache via an onion request had the wrong request structure • Fixed an issue where suspending and resuming the network without a snode cache could result in the snode cache refresh never running
• Fixed a JSON snode parsing issue (depending on the source there are different key names) • Fixed an issue where excessive path builds could get incorrectly scheduled between the current run loop and when `call_soon` kicks off the next path build build • Fixed an issue with loading swarm caches from disk • Fixed an issue where the refresh_snode_cache could get excessively called due to the retry mechanism
• Updated to latest libQuic • Updated all C functions using 'wrap_exceptions' to return a bool
• Added code to calculate swarms locally instead of fetching • Stopped persisting the 'failure_count' to disk (it gets reset when refreshing the snode cache so why bother) • Stopped persisting the swarm cache to disk (it's now calculated locally so no need)
• Increased both upload and download min path counts from 1 to 2 • Added a new `PathSelectionBehaviour` which prioritises upload/download path selection based on which has the fewest pending requests • Fixed an issue where you could end up with paths with the same IP because the `unused_nodes` wasn't getting updated after building a path
# Conflicts: # external/CMakeLists.txt # external/oxen-encoding # include/session/config.hpp # include/session/config/base.hpp # include/session/config/convo_info_volatile.hpp # include/session/config/protos.hpp # include/session/hash.hpp # include/session/session_encrypt.hpp # include/session/types.hpp # include/session/util.hpp # src/CMakeLists.txt # src/config/base.cpp # src/config/convo_info_volatile.cpp # src/config/encrypt.cpp # src/config/internal.cpp # src/config/internal.hpp # src/config/protos.cpp # src/hash.cpp # src/session_encrypt.cpp # tests/CMakeLists.txt # tests/swarm-auth-test.cpp # tests/test_blinding.cpp # tests/test_bugs.cpp # tests/test_config_contacts.cpp # tests/test_config_convo_info_volatile.cpp # tests/test_config_user_groups.cpp # tests/test_config_userprofile.cpp # tests/test_configdata.cpp # tests/test_group_info.cpp # tests/test_group_keys.cpp # tests/test_group_members.cpp # tests/test_multi_encrypt.cpp # tests/test_session_encrypt.cpp # tests/utils.hpp
…ision Renaming 'network' to 'session_network' because xcode can't debug
Added general xchacha20 encrypt/decrypt functions, doc tweaks
…-network-tests # Conflicts: # src/session_network.cpp # tests/test_session_network.cpp
(Jason amended) rewrote the comment describing the struct layout as well.
This can be very helpful to identify abnormally slow or hanging tests by trace logging every test as it runs.
More than half the CPU time in the multi-part config tests is being used generating 12k proper session IDs (via Ed keygen + conversion to X) for the test. This replaces the session id generation with random values which is sufficient for this test and takes almost no time at all.
A timeout would fail all the CHECKs, but would keep going and then throw a weird json parsing error. This fixes that by checking the success condition to a REQUIRE instead of a CHECK so that the json parsing exception doesn't happen or get reported if the request failed.
We write all held multipart values when dumping with hash as key, but that won't necessarily be properly sorted with an unordered_map, so make it sorted instead.
…-tests Fix flaky network tests
Add support for large, multi-part config messages
Renamed current_hashes on GroupKeys to active_hashes for consistency
chore: make cppcheck happy in ed25519 sign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.