Skip to content

[SES-3743] - Fix message request approval message not showing #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

SessionHero01
Copy link
Collaborator

@SessionHero01 SessionHero01 commented Apr 29, 2025

The underlying issue:

The direct cause is when someone approves you with a message, they send an approve message + reply message. Normally you'll receive them in order. But with push notification enabled, they can be out of order, so you receive the reply message first, then the approve message. If we receive a reply message, we know that person has approved you and we mark it so. Then once we process the approval message, we decide not to show it because that person was "approved" before. It's coming from the delete contact logic.

There are multiple places we can attack this problem, but a simplest one for now is to make sure we send the approval + reply messages in a strong order so they have much less chance to go out of order on the receiving side.

Technically there's nothing we can do if Google's push service decides to send them in a different order as they are very close to each other, but if we send in a strong order then there's less chance for them to send in different order.

@SessionHero01 SessionHero01 changed the title [SES-3743] - Fix message requests not showing [SES-3743] - Fix message request approval message not showing Apr 29, 2025
@SessionHero01 SessionHero01 merged commit 7bdbd3c into release/1.23.0 Apr 29, 2025
4 checks passed
@SessionHero01 SessionHero01 deleted the SES-3743-message-requests-not-showing branch April 29, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants