chore: fully type locale generated strings #1384
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilb
force-pushed
the
chore/strings-generate-types
branch
3 times, most recently
from
e4beb7a to
d9ed071
Compare
in hope that it does improve performance
Bilb
force-pushed
the
chore/strings-generate-types
branch
from
d9ed071 to
d3ddf8f
Compare
Bilb
changed the title
yougotwill
suggested changes
Apr 8, 2025
There was a problem hiding this comment.
Probably best to rebase this on top of the pino PR. I get an error in main_node.ts saying bunyan isn't found even though am using fresh node_modules.
When I try to start the app.
Unhandled Promise Rejection: TypeError: `logger.error` is required
at loadLocalizedDictionary (/Users/will/work/projects/session-desktop/ts/node/locale.js:37:15)
at App.<anonymous> (/Users/will/work/projects/session-desktop/ts/mains/main_node.js:587:67)
{"name":"log","hostname":"will-silicon.local","pid":70493,"level":50,"msg":"Unhandled Promise Rejection: {}","time":"2025-04-08T01:57:41.227Z","v":0}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.