Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix xml elements namespace and sharedString/styles file search #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dorym
Copy link

@dorym dorym commented Apr 12, 2023

This fixes 2 things:

  • I encountered some spreadsheets that have namespaces in their xml tags.
    This sets the default lookup for any namespace.
  • styles and shareStrings file paths are concatenated in a wrong way where is some
    cases the given path in workbook.xml.rels is absolute.
    I used the same solution in _parseTable(). It may be useful to extract this logic.

@sestegra
Copy link
Owner

Thank you for this PR.
Can you add a test file and a test case for it?

@sestegra sestegra added the bug label Apr 16, 2023
@sestegra
Copy link
Owner

@dorym To merge the PR, a test file and its related test case are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants