Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance lag caused by scrollbar value set invoke #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix performance lag caused by scrollbar value set invoke #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions Assets/FancyScrollView/Sources/Runtime/Scroller/Scroller.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
using UnityEngine.EventSystems;
using UnityEngine.UI;
using EasingCore;
using UnityEngine.Events;

namespace FancyScrollView
{
Expand Down Expand Up @@ -141,6 +142,11 @@ public float Position
UpdatePosition(value);
}
}

/// <summary>
/// Scrollbar onValueChangedAction
/// </summary>
private UnityAction<float> scrollbarOnValueChangedAction;

readonly AutoScrollState autoScrollState = new AutoScrollState();

Expand Down Expand Up @@ -205,7 +211,7 @@ protected override void Start()

if (scrollbar)
{
scrollbar.onValueChanged.AddListener(x => UpdatePosition(x * (totalCount - 1f), false));
scrollbarOnValueChangedAction = x => UpdatePosition(x * (totalCount - 1f), false);
}
}

Expand Down Expand Up @@ -472,9 +478,18 @@ void UpdatePosition(float position, bool updateScrollbar = true)
{
onValueChanged?.Invoke(currentPosition = position);

if (scrollbar && updateScrollbar)
if (!scrollbar)
{
return;
}

// If 'updateScrollbar' equals 'true' means this method is called by 'Scroller', otherwise from the
// scrollbar drag invoke
if (updateScrollbar)
{
scrollbar.onValueChanged.RemoveListener(scrollbarOnValueChangedAction);
scrollbar.value = Mathf.Clamp01(position / Mathf.Max(totalCount - 1f, 1e-4f));
scrollbar.onValueChanged.AddListener(scrollbarOnValueChangedAction);
}
}

Expand Down