This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
Fix/incompatible port snap #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes care of the second half of #54, where ports snapped to incompatible colors even when the connection was not possible.
There was a bug where removing an existing connection and re-wiring it to the same port would not work. This is now fixed
setzer22
commented
Sep 15, 2022
Comment on lines
+182
to
+187
| NodeData, | ||
| UserState, | ||
| DataType: DataTypeTrait<UserState>, | ||
| ValueType, | ||
| Key: slotmap::Key + Into<AnyParameterId>, | ||
| Value, |
There was a problem hiding this comment.
Unfortunately, there's no type inference, even local private functions in Rust, so we need to carry over the ugly generics from the parent calling fn 😬
This cannot be made into a closure (which would support the generics) because it needs to be called with different types, and there's no monomorphization for closures.
Comment on lines
-264
to
+295
| let other_node = self.graph.get_input(*input).node(); | ||
| let other_node = self.graph.get_output(*output).node; |
There was a problem hiding this comment.
This was a bug: When a disconnection event occurs, the node that still remains is the one attached to the output side, not the input.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes care of the second half of #54, where ports snapped to incompatible colors even when the connection was not possible. As discussed there, once we allow custom rules for connections between different colors (this was being worked on as part of #30) we will need to adapt this logic from using
==to using the custom comparison function.I also took care of a bug where removing an existing connection and re-wiring it to the same port would not work. This is now fixed.