This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
fix: result text in light mode #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamirr
reviewed
May 20, 2023
Comment on lines
+447
to
+451
| if ctx.style().visuals.dark_mode { | ||
| egui::Color32::WHITE | ||
| } else { | ||
| egui::Color32::BLACK | ||
| }, |
There was a problem hiding this comment.
This may not work properly for an arbitrary style, only the default two. I think the right approach is using ctx.style().visuals.text_color().
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the example, the result text is always white, so it is impossible to see it in light mode.